io_uring: recycle provided before arming poll
authorJens Axboe <axboe@kernel.dk>
Sun, 20 Mar 2022 00:04:41 +0000 (18:04 -0600)
committerJens Axboe <axboe@kernel.dk>
Sun, 20 Mar 2022 13:23:57 +0000 (07:23 -0600)
commitabdad709ed8fe4fd3b865ed1010de37a49601ff4
tree93e232115062ce069401429d6d31b7b451ca420a
parent5e929367468c8f97cd1ffb0417316cecfebef94b
io_uring: recycle provided before arming poll

We currently have a race where we recycle the selected buffer if poll
returns IO_APOLL_OK. But that's too late, as the poll could already be
triggering or have triggered. If that race happens, then we're putting a
buffer that's already being used.

Fix this by recycling before we arm poll. This does mean that we'll
sometimes almost instantly re-select the buffer, but it's rare enough in
testing that it should not pose a performance issue.

Fixes: b1c62645758e ("io_uring: recycle provided buffers if request goes async")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c