media: ti-vpe: cal: Fix a NULL pointer dereference in cal_ctx_v4l2_init_formats()
authorZhou Qingyang <zhou1615@umn.edu>
Mon, 24 Jan 2022 17:20:01 +0000 (18:20 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 17 Feb 2022 09:06:56 +0000 (10:06 +0100)
commitabd77889851d2ead0d0c9c4d29f1808801477b00
treef219ea3d5f2125e9c5233c3a48b3eaffeb6b66d3
parentcc74074ad9369ef54ba5d3b45edc28e9677911e7
media: ti-vpe: cal: Fix a NULL pointer dereference in cal_ctx_v4l2_init_formats()

In cal_ctx_v4l2_init_formats(), devm_kzalloc() is assigned to
ctx->active_fmt and there is a dereference of it after that, which could
lead to NULL pointer dereference on failure of devm_kzalloc().

Fix this bug by adding a NULL check of ctx->active_fmt.

This bug was found by a static analyzer.

Builds with 'make allyesconfig' show no new warnings, and our static
analyzer no longer warns about this code.

Fixes: 7168155002cf ("media: ti-vpe: cal: Move format handling to cal.c and expose helpers")
Signed-off-by: Zhou Qingyang <zhou1615@umn.edu>
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/ti-vpe/cal-video.c