drm/amdkfd: potential NULL dereference in kfd_set/reset_event()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 13 Apr 2022 07:36:40 +0000 (10:36 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 14 Apr 2022 19:24:22 +0000 (15:24 -0400)
commitabb5bc59490067b88ed006cdb58f3ff1d12057cc
tree253ca9eaca167521e89038f544d0b74ce12bd13e
parent46d18d510d78318c4aa5aaeff66782f1ec42c2ec
drm/amdkfd: potential NULL dereference in kfd_set/reset_event()

If lookup_event_by_id() returns a NULL "ev" pointer then the
spin_lock(&ev->lock) will crash.  This was detected by Smatch:

    drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_events.c:644 kfd_set_event()
    error: we previously assumed 'ev' could be null (see line 639)

Fixes: 5273e82c5f47 ("drm/amdkfd: Improve concurrency of event handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_events.c