[Driver] Change CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL to affect driver default instea...
authorFangrui Song <i@maskray.me>
Wed, 13 Apr 2022 23:58:00 +0000 (16:58 -0700)
committerFangrui Song <i@maskray.me>
Wed, 13 Apr 2022 23:58:00 +0000 (16:58 -0700)
commitab8abeaf48abb3addcbdb6136b1975b4afa3b37c
tree36e96688cf8446c7d63a885890a3e981d23375e5
parentd3531fc7f0053a7fe68317521ee6491da6e36733
[Driver] Change CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL to affect driver default instead of cc1 default

The current cc1 CLANG_ENABLE_OPAQUE_POINTERS=on default difference is not ideal
in that people contribute %clang_cc1 tests may assume the default ON behavior,
which will cause failures on systems set to OFF.

cc1 option default dependent on CMake options should be used prudently
(generally avoided). We prefer to limit target differences to Driver.

Change the CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL mechanism introduced in D123122
to use a driver default instead. This is similar to the mechanism used for the
-flegacy-pass-manager transition to new PM transition.

Reviewed By: #opaque-pointers, rsmith, aeubanks

Differential Revision: https://reviews.llvm.org/D123744
clang/include/clang/Driver/Options.td
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/CMakeLists.txt
clang/test/Driver/opaque-pointers-off.c [new file with mode: 0644]
clang/test/Driver/rewrite-legacy-objc.m
clang/test/Driver/rewrite-objc.m
clang/test/lit.cfg.py
clang/test/lit.site.cfg.py.in