Avoid two-stage initialization of MinidumpParser
authorPavel Labath <pavel@labath.sk>
Fri, 22 Feb 2019 13:36:01 +0000 (13:36 +0000)
committerPavel Labath <pavel@labath.sk>
Fri, 22 Feb 2019 13:36:01 +0000 (13:36 +0000)
commitab86d3da7ac4e85e9f363fe3a74a21d61e719a9d
treea04e3bc39e73679c675c6238cce52017c6d33996
parentacb628b2afb4b43dd0224c393f1ff47abd3b9045
Avoid two-stage initialization of MinidumpParser

remove the Initialize function, move the things that can fail into the
static factory function. The factory function now returns
Expected<Parser> instead of Optional<Parser> so that it can give a
reason why creation failed.

llvm-svn: 354668
lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
lldb/source/Plugins/Process/minidump/MinidumpParser.h
lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
lldb/source/Plugins/Process/minidump/ProcessMinidump.h
lldb/unittests/Process/minidump/CMakeLists.txt
lldb/unittests/Process/minidump/MinidumpParserTest.cpp