l2tp: WARN_ON rather than BUG_ON in l2tp_session_free
authorTom Parkin <tparkin@katalix.com>
Fri, 24 Jul 2020 15:31:57 +0000 (16:31 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 25 Jul 2020 00:19:14 +0000 (17:19 -0700)
commitab6934e084e5eee665adf6e834e5096ebae4a95f
tree87056210a3a52fc56229ef5d44d0392d1fceb10e
parent0dd62f69d898de3cf31a2f8b59e9a62bb5448457
l2tp: WARN_ON rather than BUG_ON in l2tp_session_free

l2tp_session_free called BUG_ON if the tunnel magic feather value wasn't
correct.  The intent of this was to catch lifetime bugs; for example
early tunnel free due to incorrect use of reference counts.

Since the tunnel magic feather being wrong indicates either early free
or structure corruption, we can avoid doing more damage by simply
leaving the tunnel structure alone.  If the tunnel refcount isn't
dropped when it should be, the tunnel instance will remain in the
kernel, resulting in the tunnel structure and socket leaking.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/l2tp/l2tp_core.c