objtool: Allow no-op CFI ops in alternatives
authorPeter Zijlstra <peterz@infradead.org>
Fri, 8 May 2020 10:34:33 +0000 (12:34 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 15 May 2020 08:35:12 +0000 (10:35 +0200)
commitab3852ab5cb8fd2e2c5bfa176e5f953353836907
tree06b5772f99cd8e99d278db1f3ee8b328953b5658
parentcc1ac9c792810b93783a7de344f428922af8d98c
objtool: Allow no-op CFI ops in alternatives

Randy reported a false-positive:

  arch/x86/hyperv/hv_apic.o: warning: objtool: hv_apic_write()+0x25: alternative modifies stack

What happens is that:

alternative_io("movl %0, %P1", "xchgl %0, %P1", X86_BUG_11AP,
 13d:   89 9d 00 d0 7f ff       mov    %ebx,-0x803000(%rbp)

decodes to an instruction with CFI-ops because it modifies RBP.
However, due to this being a !frame-pointer build, that should not in
fact change the CFI state.

So instead of dis-allowing any CFI-op, verify the op would've actually
changed the CFI state.

Fixes: 7117f16bf460 ("objtool: Fix ORC vs alternatives")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
tools/objtool/check.c