[lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode
authorAlex Langford <alangford@apple.com>
Thu, 25 May 2023 23:22:13 +0000 (16:22 -0700)
committerAlex Langford <alangford@apple.com>
Thu, 1 Jun 2023 17:03:56 +0000 (10:03 -0700)
commitab27431596c4f61f84ce41e27aad09a4dde3fc5a
tree8f2d25b4c3bd9b0e7cb2ae8f7efacab1ad3a0061
parent8998ff53c91687b1065d095f6ac0ad7578131d73
[lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode

On llvm.org and all downstream forks that I'm aware of, SignalCodes are
always created from C string literals. They are never compared to
anything so they take up space in the ConstString StringPool for no
tangible benefit.

I've changed the type here to `const llvm::StringLiteral` instead of
using a `StringRef` or a `const char *` to express intent -- These
strings come from constant data whose lifetime is directly tied to that
of the running process (and are thus safe to store).

Differential Revision: https://reviews.llvm.org/D151516
lldb/include/lldb/Target/UnixSignals.h
lldb/source/Target/UnixSignals.cpp