drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked
authorAshutosh Dixit <ashutosh.dixit@intel.com>
Wed, 24 May 2023 21:56:28 +0000 (14:56 -0700)
committerAshutosh Dixit <ashutosh.dixit@intel.com>
Wed, 31 May 2023 20:23:16 +0000 (13:23 -0700)
commitab12902528f414cbb68d0da2b0d518b0ef10e696
treef6bd4ecaede695c989cc45780828a5d733f0f53c
parent09a36015d9a0940214c080f95afc605c47648bbd
drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked

pmu_needs_timer() keeps the timer running even when GT is parked,
ostensibly to sample requested/actual frequencies. However
frequency_sample() has the following:

/* Report 0/0 (actual/requested) frequency while parked. */
if (!intel_gt_pm_get_if_awake(gt))
return;

The above code prevents frequencies to be sampled while the GT is
parked. So we might as well turn off the sampling timer itself in this
case and save CPU cycles/power.

v2: Instead of turning freq bits off, return false, since no counters will
    run after this change when GT is parked (Tvrtko)
v3: Remove gpu_active argument of pmu_needs_timer (Andrzej)

Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230524215629.97920-2-ashutosh.dixit@intel.com
drivers/gpu/drm/i915/i915_pmu.c