Revert "NFSv4: Handle the special Linux file open access mode"
authorChenXiaoSong <chenxiaosong2@huawei.com>
Tue, 29 Mar 2022 11:32:07 +0000 (19:32 +0800)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Wed, 30 Mar 2022 02:14:00 +0000 (22:14 -0400)
commitab0fc21bc7105b54bafd85bd8b82742f9e68898a
treef8596336e2328573fa67d3c72329291fb72dd415
parent7c9d845f0612e5bcd23456a2ec43be8ac43458f1
Revert "NFSv4: Handle the special Linux file open access mode"

This reverts commit 44942b4e457beda00981f616402a1a791e8c616e.

After secondly opening a file with O_ACCMODE|O_DIRECT flags,
nfs4_valid_open_stateid() will dereference NULL nfs4_state when lseek().

Reproducer:
  1. mount -t nfs -o vers=4.2 $server_ip:/ /mnt/
  2. fd = open("/mnt/file", O_ACCMODE|O_DIRECT|O_CREAT)
  3. close(fd)
  4. fd = open("/mnt/file", O_ACCMODE|O_DIRECT)
  5. lseek(fd)

Reported-by: Lyu Tao <tao.lyu@epfl.ch>
Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/inode.c
fs/nfs/nfs4file.c