Nullable: globalization remainder (dotnet/coreclr#23526)
authorKrzysztof Wicher <mordotymoja@gmail.com>
Tue, 2 Apr 2019 16:07:08 +0000 (09:07 -0700)
committerGitHub <noreply@github.com>
Tue, 2 Apr 2019 16:07:08 +0000 (09:07 -0700)
commitab0bff5b12291b7037e3ccd214a51fe58a731170
tree055bc6549dd93b75d33092ff41abdfd6a89ca7aa
parent7120a4bfd2ff3a97d1e45c7d3921095294deef6a
Nullable: globalization remainder (dotnet/coreclr#23526)

* Nullable: remainder of globalization

* annotate windows specific files

* add TODO-NULLABLE next to TODO suggesting comments

* fixes after merging other globalization annotations, apply feedback

* fix windows

* address feedback

* fix windows

* fixes

* apply feedback

* remove workaround

* s_Invariant?, couple of Debug.Asserts

Commit migrated from https://github.com/dotnet/coreclr/commit/d073a1721e4893d8ebf7c384f1d6ee6bb9711f16
50 files changed:
src/libraries/System.Private.CoreLib/src/System/Globalization/Calendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CalendarData.Unix.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CalendarData.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/ChineseLunisolarCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.Invariant.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.Unix.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.Windows.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Unix.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Windows.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureInfo.Unix.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureInfo.Windows.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureInfo.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureNotFoundException.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeFormatInfo.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeParse.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/DaylightTime.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationExtensions.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/GregorianCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/GregorianCalendarHelper.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/HebrewCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/HebrewNumber.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/HijriCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/ISOWeek.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/IdnMapping.Unix.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/IdnMapping.Windows.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/IdnMapping.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/InternalGlobalizationHelper.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/JapaneseCalendar.Unix.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/JapaneseCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/JapaneseLunisolarCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/JulianCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/KoreanCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/KoreanLunisolarCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/LocaleData.Unix.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.Unix.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.Windows.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/NumberFormatInfo.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/PersianCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/RegionInfo.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/SortVersion.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/StringInfo.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/TaiwanCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/TaiwanLunisolarCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/TextInfo.Unix.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/TextInfo.Windows.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/TextInfo.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/ThaiBuddhistCalendar.cs
src/libraries/System.Private.CoreLib/src/System/Globalization/UmAlQuraCalendar.cs