vhost_net: start/stop guest notifiers properly
authorJason Wang <jasowang@redhat.com>
Tue, 19 Aug 2014 04:56:29 +0000 (12:56 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 2 Sep 2014 14:33:37 +0000 (17:33 +0300)
commitaad4dce934649b3a398396fc2a76f215bb194ea4
tree54e4c1af86673d3f3d333683079816112ae57d4a
parentd7efb7e08e5edaac23b0dc824f72c3f353447c39
vhost_net: start/stop guest notifiers properly

commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue
support changed the order of stopping the device. Previously
vhost_dev_stop would disable backend and only afterwards, unset guest
notifiers. We now unset guest notifiers while vhost is still
active. This can lose interrupts causing guest networking to fail. In
particular, this has been observed during migration.

To adapt this, several other changes are needed:
- remove the hdev->started assertion in vhost.c since we may want to
start the guest notifiers before vhost starts and stop the guest
notifiers after vhost is stopped.
- introduce the vhost_net_set_vq_index() and call it before setting
guest notifiers. This is used to guarantee vhost_net has the correct
virtqueue index when setting guest notifiers.

Cc: qemu-stable@nongnu.org
Reported-by: "Zhangjie (HZ)" <zhangjie14@huawei.com>
Tested-by: William Dauchy <wdauchy@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/net/vhost_net.c
hw/virtio/vhost.c