Remove build warning at RISCV 27/301427/3
authorEunki Hong <eunkiki.hong@samsung.com>
Wed, 15 Nov 2023 16:33:23 +0000 (01:33 +0900)
committerEunki, Hong <eunkiki.hong@samsung.com>
Thu, 16 Nov 2023 01:47:30 +0000 (10:47 +0900)
commitaac5eb3852b66e4e03909fa3719a146266b73a90
treef8ac3c0fa494011e5a908254fcc3014b9b04b8b4
parentdbde4ec5a65e6a0b5b79a7276953618af458dc1a
Remove build warning at RISCV

Resolve 3 kinds of build warning messages

1. -Wpessimizing-move
[   48s] /home/abuild/rpmbuild/BUILD/dali2-adaptor-2.2.52/dali/internal/canvas-renderer/tizen/canvas-renderer-impl-tizen.cpp:543:50: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
[   48s]   543 |       if(tvgDuplicatedObject->composite(std::move(std::unique_ptr<tvg::Paint>(tvgDuplicatedCompositeObject)), static_cast<tvg::CompositeMethod>(drawableImpl.GetCompositionType())) != tvg::Result::Success)
[   48s]       |                                         ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[   48s] /home/abuild/rpmbuild/BUILD/dali2-adaptor-2.2.52/dali/internal/canvas-renderer/tizen/canvas-renderer-impl-tizen.cpp:543:50: note: remove 'std::move' call

2. -Wmaybe-uninitialized
[   48s] /home/abuild/rpmbuild/BUILD/dali2-adaptor-2.2.52/dali/internal/adaptor/tizen-wayland/framework-tizen.cpp:1353:3: warning: 'ret' may be used uninitialized [-Wmaybe-uninitialized]
[   48s]  1353 |   if(ret != APP_ERROR_NONE)
[   48s]       |   ^~
[   48s] /home/abuild/rpmbuild/BUILD/dali2-adaptor-2.2.52/dali/internal/adaptor/tizen-wayland/framework-tizen.cpp:752:9: note: 'ret' was declared here
[   48s]   752 |     int ret;
[   48s]       |         ^~~

3. -Wsign-compare
[  116s] /home/abuild/rpmbuild/BUILD/dali2-adaptor-2.2.52/dali/internal/drag-and-drop/tizen-wayland/drag-and-drop-impl-ecore-wl2.cpp:453:18: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare]
[  116s]   453 |       if(ev->win == mDropWindowTargets[i].windowId)
[  116s]       |          ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

TODO : Can we remove deprecated widget application codes?

Change-Id: I776de1726c92c2ae4be5519db38a92a0543e4cc0
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
automated-tests/src/dali-adaptor-internal/utc-Dali-FontClient.cpp
dali/internal/adaptor/tizen-wayland/framework-tizen.cpp
dali/internal/canvas-renderer/tizen/canvas-renderer-impl-tizen.cpp
dali/internal/drag-and-drop/tizen-wayland/drag-and-drop-impl-ecore-wl2.cpp