Reduce <limits.h> pollution due to dynamic PTHREAD_STACK_MIN
authorFlorian Weimer <fweimer@redhat.com>
Mon, 12 Jul 2021 16:43:32 +0000 (18:43 +0200)
committerFlorian Weimer <fweimer@redhat.com>
Mon, 12 Jul 2021 16:43:32 +0000 (18:43 +0200)
commitaaacde11f2e814814fdd19dfb683e76f1dede4d5
tree6521bf547f60de04b02c84e542e87daccb4636e9
parent8235f9311bddbe4cf8ff1fa8f72f41aa77e27e00
Reduce <limits.h> pollution due to dynamic PTHREAD_STACK_MIN

<limits.h> used to be a header file with no declarations.
GCC's libgomp includes it in a #pragma GCC visibility hidden block.
Including <unistd.h> from <limits.h> (indirectly) declares everything
in <unistd.h> with hidden visibility, resulting in linker failures.

This commit avoids C declarations in assembler mode and only declares
__sysconf in <limits.h> (and not the entire contents of <unistd.h>).
The __sysconf symbol is already part of the ABI.  PTHREAD_STACK_MIN
is no longer defined for __USE_DYNAMIC_STACK_SIZE && __ASSEMBLER__
because there is no possible definition.

Additionally, PTHREAD_STACK_MIN is now defined by <pthread.h> for
__USE_MISC because this is what developers expect based on the macro
name.  It also helps to avoid libgomp linker failures in GCC because
libgomp includes <pthread.h> before its visibility hacks.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
include/bits/local_lim.h [deleted file]
nptl/tst-minstack-exit.c
sysdeps/nptl/pthread.h
sysdeps/unix/sysv/linux/Makefile
sysdeps/unix/sysv/linux/bits/local_lim.h
sysdeps/unix/sysv/linux/bits/pthread_stack_min-dynamic.h [new file with mode: 0644]
sysdeps/unix/sysv/linux/include/bits/pthread_stack_min-dynamic.h [new file with mode: 0644]