qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration
authorPeter Maydell <peter.maydell@linaro.org>
Wed, 26 Feb 2014 23:51:46 +0000 (23:51 +0000)
committerMichael Tokarev <mjt@tls.msk.ru>
Mon, 3 Mar 2014 05:45:46 +0000 (09:45 +0400)
commitaa830cdc28edb69c1fe81c8fd9471ab288ad0926
treefc233fab9aca88e916d0f761a469aba619250bb0
parent7edd9ddc979f112287ff5184590830c67ea991bf
qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration

The function qobject_from_json() doesn't actually allow its
argument to be a format string -- it passes a NULL va_list*
to qobject_from_jsonv(), and the parser code will then never
actually interpret %-escape sequences (it tests whether the
va_list pointer is NULL and will stop with a parse error).

The spurious attribute markup causes clang warnings in some
of the test cases where we programmatically construct JSON
to feed to qobject_from_json():

 tests/test-qmp-input-visitor.c:76:35: warning: format string is not a
 string literal (potentially insecure) [-Wformat-security]
    data->obj = qobject_from_json(json_string);
                                  ^~~~~~~~~~~

Remove the incorrect attribute.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
include/qapi/qmp/qjson.h