ASoC: intel: atom: Stop advertising non working S24LE support
authorHans de Goede <hdegoede@redhat.com>
Wed, 24 Mar 2021 13:27:10 +0000 (14:27 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 24 Mar 2021 19:48:04 +0000 (19:48 +0000)
commitaa65bacdb70e549a81de03ec72338e1047842883
treeb511a6cba2bc25845149262b99332259661e1d77
parent2c0d7f9186d06f1f3f6c52387195c8f89070af93
ASoC: intel: atom: Stop advertising non working S24LE support

The SST firmware's media and deep-buffer inputs are hardcoded to
S16LE, the corresponding DAIs don't have a hw_params callback and
their prepare callback also does not take the format into account.

So far the advertising of non working S24LE support has not caused
issues because pulseaudio defaults to S16LE, but changing pulse-audio's
config to use S24LE will result in broken sound.

Pipewire is replacing pulse now and pipewire prefers S24LE over S16LE
when available, causing the problem of the broken S24LE support to
come to the surface now.

Cc: stable@vger.kernel.org
BugLink: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/866
Fixes: 098c2cd281409 ("ASoC: Intel: Atom: add 24-bit support for media playback and capture")
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210324132711.216152-2-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/atom/sst-mfld-platform-pcm.c