llc: set SOCK_RCU_FREE in llc_sap_add_socket()
authorCong Wang <xiyou.wangcong@gmail.com>
Thu, 11 Oct 2018 18:15:13 +0000 (11:15 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 10 Nov 2018 15:42:57 +0000 (07:42 -0800)
commitaa23c2207d2911d04df76001cd98d212cedfe69b
tree207c7cf6fe3d89786a6b545b2426a4948e6c2364
parent510e6c3bd51ac59c0ff2296c2ce84529ac7cfbfc
llc: set SOCK_RCU_FREE in llc_sap_add_socket()

[ Upstream commit 5a8e7aea953bdb6d4da13aff6f1e7f9c62023499 ]

WHen an llc sock is added into the sk_laddr_hash of an llc_sap,
it is not marked with SOCK_RCU_FREE.

This causes that the sock could be freed while it is still being
read by __llc_lookup_established() with RCU read lock. sock is
refcounted, but with RCU read lock, nothing prevents the readers
getting a zero refcnt.

Fix it by setting SOCK_RCU_FREE in llc_sap_add_socket().

Reported-by: syzbot+11e05f04c15e03be5254@syzkaller.appspotmail.com
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/llc/llc_conn.c