bluetooth: Reorganize code to avoid Coverity NULL dereference warning
authorPeter Meerwald-Stadler <pmeerw@pmeerw.net>
Tue, 16 Aug 2016 13:33:24 +0000 (15:33 +0200)
committerPeter Meerwald-Stadler <pmeerw@pmeerw.net>
Wed, 17 Aug 2016 15:32:03 +0000 (17:32 +0200)
commitaa1882c93f8a001880d8a51f48f2efee1221c090
tree6f88008dd457e291f2a120db5932bb98fe9f0287
parent41a2849261c75b4b6743ff4f49582eb1f671ed33
bluetooth: Reorganize code to avoid Coverity NULL dereference warning

CID 1353122

this is a false-positive because

   if (dbus_message_has_interface(p->message, "org.bluez.Manager") ||
        dbus_message_has_interface(p->message, "org.bluez.Adapter"))
        d = NULL;
    else if (!(d = pa_hashmap_get(y->devices, dbus_message_get_path(p->message)))) {
        pa_log_warn("Received GetProperties() reply from unknown device: %s (device removed?)",
dbus_message_get_path(p->message));
        goto finish2;
    }

d can be NULL only if p->message interface is org.bluez.Manager or
org.bluez.Adapter. If

    dbus_message_is_method_call(p->message, "org.bluez.Device", "GetProperties")

returns true, we know that the interface is org.bluez.Device.

thanks, Tanu!
src/modules/bluetooth/bluez4-util.c