media: amphion: fix some issues to improve robust
authorMing Qian <ming.qian@nxp.com>
Fri, 11 Mar 2022 05:17:07 +0000 (06:17 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 18 Mar 2022 06:32:10 +0000 (07:32 +0100)
commita9f7224c67b3357e6585e6ddbcabd0523ca0f39f
treea7651d8431b0b042757c14c4c5268ad16cf5f9a5
parent05a03eff34ba7de2d3e50a92961850d5e0f14f34
media: amphion: fix some issues to improve robust

fix some issues reported by Dan,
1. fix some signedness bug
2. don't use u32 as function return value
3. prevent a divide by zero bug
4. Just return zero on success, don't return a known parameter
5. check the validity of some variables
6. reset buffer state when return buffers
7. make sure the ALIGN won't wrap to zero

Signed-off-by: Ming Qian <ming.qian@nxp.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/amphion/vpu_core.c
drivers/media/platform/amphion/vpu_helpers.c
drivers/media/platform/amphion/vpu_helpers.h
drivers/media/platform/amphion/vpu_imx8q.c
drivers/media/platform/amphion/vpu_imx8q.h
drivers/media/platform/amphion/vpu_malone.c
drivers/media/platform/amphion/vpu_msgs.c
drivers/media/platform/amphion/vpu_rpc.c
drivers/media/platform/amphion/vpu_rpc.h
drivers/media/platform/amphion/vpu_v4l2.c
drivers/media/platform/amphion/vpu_windsor.c