packet: fix race condition in packet_set_ring accepted/tizen/3.0/common/20161209.161059 accepted/tizen/3.0/ivi/20161209.104110 accepted/tizen/3.0/mobile/20161209.104016 accepted/tizen/3.0/tv/20161209.104035 accepted/tizen/3.0/wearable/20161209.104101 submit/tizen_3.0/20161209.020613
authorPhilip Pettersson <philip.pettersson@gmail.com>
Tue, 6 Dec 2016 23:51:56 +0000 (08:51 +0900)
committerInki Dae <inki.dae@samsung.com>
Fri, 9 Dec 2016 02:00:50 +0000 (11:00 +0900)
commita9ec90796325f878ea54e4c1a1faac92ef1a5cbd
tree27bd729bf3ee793320f377b41683254ea53af49a
parent5f467403301b0e752b2d6562e05ad8686a26de5a
packet: fix race condition in packet_set_ring

When packet_set_ring creates a ring buffer it will initialize a
struct timer_list if the packet version is TPACKET_V3. This value
can then be raced by a different thread calling setsockopt to
set the version to TPACKET_V1 before packet_set_ring has finished.

This leads to a use-after-free on a function pointer in the
struct timer_list when the socket is closed as the previously
initialized timer will not be deleted.

The bug is fixed by taking lock_sock(sk) in packet_setsockopt when
changing the packet version while also taking the lock at the start
of packet_set_ring.

Ps. This is CVE-2016-8655 patch,
http://seclists.org/oss-sec/2016/q4/607

Change-Id: I3396f1bfe60b03082a981ae9d8a787b41cb5a529
Fixes: f6fb8f100b80 ("af-packet: TPACKET_V3 flexible buffer implementation.")
Signed-off-by: Philip Pettersson <philip.pettersson@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
net/packet/af_packet.c