reiserfs: Force inode evictions before umount to avoid crash
authorJeff Mahoney <jeffm@suse.com>
Wed, 21 Dec 2011 20:18:43 +0000 (21:18 +0100)
committerJan Kara <jack@suse.cz>
Mon, 9 Jan 2012 12:52:09 +0000 (13:52 +0100)
commita9e36da655e54545c3289b2a0700b5c443de0edd
tree14143a3c873177b70b8b66d6f8085378a2c92908
parenta06d789b424190e9f59da391681f908486db2554
reiserfs: Force inode evictions before umount to avoid crash

This patch fixes a crash in reiserfs_delete_xattrs during umount.

When shrink_dcache_for_umount clears the dcache from
generic_shutdown_super, delayed evictions are forced to disk. If an
evicted inode has extended attributes associated with it, it will
need to walk the xattr tree to locate and remove them.

But since shrink_dcache_for_umount will BUG if it encounters active
dentries, the xattr tree must be released before it's called or it will
crash during every umount.

This patch forces the evictions to occur before generic_shutdown_super
by calling shrink_dcache_sb first. The additional evictions caused
by the removal of each associated xattr file and dir will be automatically
handled as they're added to the LRU list.

CC: reiserfs-devel@vger.kernel.org
CC: stable@kernel.org
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/reiserfs/super.c