Fix latent bug in test_gdb_complete_cmd_multiple
authorPedro Alves <palves@redhat.com>
Wed, 3 Jul 2019 15:57:50 +0000 (16:57 +0100)
committerPedro Alves <palves@redhat.com>
Wed, 3 Jul 2019 16:09:16 +0000 (17:09 +0100)
commita994424fa1e80d982644038f1ce6538e247aeed1
tree8b22027e66cc8f4d58193df3a223a8b79628835e
parent3d9be6f531db395a5ad940ef06e56d849f4de646
Fix latent bug in test_gdb_complete_cmd_multiple

A following patch will add the following to a testcase:

  test_gdb_completion_offers_commands "| "

And that tripped on a latent testsuite bug:

 (gdb) | PASS: gdb.base/shell.exp: tab complete "| "
 ^CQuit
 (gdb) complete |
 | !
 | +
 PASS: gdb.base/shell.exp: cmd complete "| "
 |  *** List may be truncated, max-completions reached. ***
 (gdb) FAIL: gdb.base/shell.exp: set max-completions 200
 set max-completions 200

The issue is that "|" ends up as part of a regexp, and "|" in regexps
has a special meaning...

Fix this with string_to_regexp.

gdb/testsuite/ChangeLog:
2019-07-03  Pedro Alves  <palves@redhat.com>

* lib/completion-support.exp (test_gdb_complete_cmd_multiple): Use
string_to_regexp.
gdb/testsuite/ChangeLog
gdb/testsuite/lib/completion-support.exp