USB: serial: ti_usb_3410_5052: fix array underflow in completion handler
authorJohan Hovold <johan@kernel.org>
Tue, 21 Aug 2018 09:59:53 +0000 (11:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Sep 2018 06:38:08 +0000 (08:38 +0200)
commita98152a6feaa64c33684097eaeb4ff225fab8fca
tree321069e51cddbc2d56d6df7e8f904477c77c5b21
parenta82200ced75f366e6d0740bf8a6fae3a212ea84c
USB: serial: ti_usb_3410_5052: fix array underflow in completion handler

commit 5dfdd24eb3d39d815bc952ae98128e967c9bba49 upstream.

Similarly to a recently reported bug in io_ti, a malicious USB device
could set port_number to a negative value and we would underflow the
port array in the interrupt completion handler.

As these devices only have one or two ports, fix this by making sure we
only consider the seventh bit when determining the port number (and
ignore bits 0xb0 which are typically set to 0x30).

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/ti_usb_3410_5052.c