futex: Return error code instead of assigning it without effect
authorColin Ian King <colin.king@canonical.com>
Wed, 18 Aug 2021 13:18:40 +0000 (14:18 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 2 Sep 2021 20:07:18 +0000 (22:07 +0200)
commita974b54036f79dd5e395e9f6c80c3decb4661a14
treecbb228b620a015624f929d691f54c7d22a77130d
parent15eb7c888e749fbd1cc0370f3d38de08ad903700
futex: Return error code instead of assigning it without effect

The check on the rt_waiter and top_waiter->pi_state is assigning an error
return code to ret but this later gets re-assigned, hence the check is
ineffective.

Return -EINVAL rather than assigning it to ret which was the original
intent.

Fixes: dc7109aaa233 ("futex: Validate waiter correctly in futex_proxy_trylock_atomic()")
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: André Almeida <andrealmeid@collabora.com>
Link: https://lore.kernel.org/r/20210818131840.34262-1-colin.king@canonical.com
kernel/futex.c