ethtool: avoiding integer overflow in ethtool_phys_id()
authorMaxim Korotkov <korotkov.maxim.s@gmail.com>
Tue, 22 Nov 2022 12:29:01 +0000 (15:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:14:42 +0000 (13:14 +0100)
commita96841f5aa4597e93c1f4d6fffb91a5ee344e6e6
tree879a43e003b427147c7ad6a72541ade3ebe6cd61
parentb327c68ace71ba9cb3105ae6a5955a229e9bdca3
ethtool: avoiding integer overflow in ethtool_phys_id()

[ Upstream commit 64a8f8f7127da228d59a39e2c5e75f86590f90b4 ]

The value of an arithmetic expression "n * id.data" is subject
to possible overflow due to a failure to cast operands to a larger data
type before performing arithmetic. Used macro for multiplication instead
operator for avoiding overflow.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20221122122901.22294-1-korotkov.maxim.s@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/ethtool/ioctl.c