pinctrl: qcom: Properly clear "intr_ack_high" interrupts when unmasking
authorDouglas Anderson <dianders@chromium.org>
Fri, 15 Jan 2021 03:16:23 +0000 (19:16 -0800)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 18 Jan 2021 15:07:08 +0000 (16:07 +0100)
commita95881d6aa2c000e3649f27a1a7329cf356e6bb3
tree718dc07065b413ae96c93cb89e8ca039ea684114
parent4079d35fa4fca4ee0ffd66968312fc86a5e8c290
pinctrl: qcom: Properly clear "intr_ack_high" interrupts when unmasking

In commit 4b7618fdc7e6 ("pinctrl: qcom: Add irq_enable callback for
msm gpio") we tried to Ack interrupts during unmask.  However, that
patch forgot to check "intr_ack_high" so, presumably, it only worked
for a certain subset of SoCs.

Let's add a small accessor so we don't need to open-code the logic in
both places.

This was found by code inspection.  I don't have any access to the
hardware in question nor software that needs the Ack during unmask.

Fixes: 4b7618fdc7e6 ("pinctrl: qcom: Add irq_enable callback for msm gpio")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Maulik Shah <mkshah@codeaurora.org>
Tested-by: Maulik Shah <mkshah@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20210114191601.v7.3.I32d0f4e174d45363b49ab611a13c3da8f1e87d0f@changeid
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-msm.c