brcmfmac: fix leak of mypkt on error return path
authorColin Ian King <colin.king@canonical.com>
Tue, 9 Apr 2019 11:43:33 +0000 (12:43 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 13 Apr 2019 11:07:09 +0000 (14:07 +0300)
commita927e8d8ab57e696800e20cf09a72b7dfe3bbebb
tree4f8dd99daf01eed6a63eb1f6a72e40a6659788d5
parente3062e05e1cfe378bb9b3fa0bef46711372bcf13
brcmfmac: fix leak of mypkt on error return path

Currently if the call to brcmf_sdiod_set_backplane_window fails then
error return path leaks mypkt. Fix this by returning by a new
error path labelled 'out' that calls brcmu_pkt_buf_free_skb to free
mypkt.  Also remove redundant check on err before calling
brcmf_sdiod_skbuff_write.

Addresses-Coverity: ("Resource Leak")
Fixes: a7c3aa1509e2 ("brcmfmac: Remove brcmf_sdiod_addrprep()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c