target/iscsi: Fix double free in lio_target_tiqn_addtpg()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 13 Dec 2016 12:27:04 +0000 (15:27 +0300)
committerBart Van Assche <bart.vanassche@sandisk.com>
Fri, 16 Dec 2016 10:15:11 +0000 (11:15 +0100)
commita91918cd3ea11f91c68e08e1e8ce1b560447a80e
tree82866d98bcc777681126d4aea07ee1e5dc5ee581
parentd0905ca757bc40bd1ebc261a448a521b064777d7
target/iscsi: Fix double free in lio_target_tiqn_addtpg()

This iscsit_tpg_add_portal_group() function is only called from
lio_target_tiqn_addtpg().  Both functions free the "tpg" pointer on
error so it's a double free bug.  The memory is allocated in the caller
so it should be freed in the caller and not here.

Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
[ bvanassche: Added "Fix" at start of patch title ]
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
drivers/target/iscsi/iscsi_target_tpg.c