Remove buildtools imports from Directory.Build.* (dotnet/corefx#34001)
authorEric StJohn <ericstj@microsoft.com>
Mon, 28 Jan 2019 22:18:49 +0000 (14:18 -0800)
committerGitHub <noreply@github.com>
Mon, 28 Jan 2019 22:18:49 +0000 (14:18 -0800)
commita9106dbe9e147adfe99170825e09acbe67ab7acc
tree941f324a9b47fddf6e37c6d717c31cd1ef2e40f3
parent65acfff45c5603968660aeed4fa7a5d2234f488d
Remove buildtools imports from Directory.Build.* (dotnet/corefx#34001)

* Remove buildtools imports from Directory.Build.*

Remove buildtools imports and implement remaining functionality in CoreFx.

I was able to do most of what BuildTools was doing with 3 exceptions, which will be split into separate issues.
1. Test shared framework deps file: GenerateDepsJson.  We need to port this task to arcade or change how we test to not need it.
2. codeOptimization.targets -> should be moved to arcade, work is pending.
3. optionalTooling.targets -> move to a CSProj that is restored by the official build workflow.

* Address feedack, fix unix and UAP build issues

* Fix UWP, Tizen, and AllConfigurations build

* Remove buildtools dependency from package testing

* Remove a few more buildtools dependencies

* Eliminate RunningOnUnix property

* Remove NuGetTargetMoniker from shims.proj

* Remove ResourcesFolderPath

* Fix Microsoft.XmlSerializer.Generator.Tests

* Specify NuGetTargetMoniker for shims

* Remove a couple remaining ToolsDir uses

Commit migrated from https://github.com/dotnet/corefx/commit/49d249fa023e8575dba7e35febb4446e4fa13f98
19 files changed:
eng/BlockReflectionAttribute.cs [new file with mode: 0644]
eng/blockReflectionAttribute.targets [new file with mode: 0644]
eng/illink.targets
eng/referenceFromRuntime.targets
eng/references.targets [new file with mode: 0644]
eng/versioning.targets
src/libraries/Common/src/System/Security/Cryptography/Asn1/AsnXml.targets
src/libraries/Microsoft.XmlSerializer.Generator/tests/Microsoft.XmlSerializer.Generator.Tests.csproj
src/libraries/SharedFrameworkValidation/SharedFrameworkValidation.proj
src/libraries/build.proj
src/libraries/dir.traversal.targets
src/libraries/dirs.proj
src/libraries/external/runtime/runtime.depproj
src/libraries/packages.builds
src/libraries/pkg/test/packageTest.targets
src/libraries/pkg/test/testPackages.proj
src/libraries/shims/Directory.Build.props
src/libraries/shims/shims.proj
src/libraries/tests.builds