RDMA/uverbs: Prevent potential underflow
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 11 Oct 2019 13:34:19 +0000 (16:34 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 22 Oct 2019 18:05:36 +0000 (15:05 -0300)
commita9018adfde809d44e71189b984fa61cc89682b5e
tree144524aac0d81b2e3c726df9382fb0dc0ba9c978
parent777a8b32bc0f9bb25848a025f72a9febc30d9033
RDMA/uverbs: Prevent potential underflow

The issue is in drivers/infiniband/core/uverbs_std_types_cq.c in the
UVERBS_HANDLER(UVERBS_METHOD_CQ_CREATE) function.  We check that:

        if (attr.comp_vector >= attrs->ufile->device->num_comp_vectors) {

But we don't check if "attr.comp_vector" is negative.  It could
potentially lead to an array underflow.  My concern would be where
cq->vector is used in the create_cq() function from the cxgb4 driver.

And really "attr.comp_vector" is appears as a u32 to user space so that's
the right type to use.

Fixes: 9ee79fce3642 ("IB/core: Add completion queue (cq) object actions")
Link: https://lore.kernel.org/r/20191011133419.GA22905@mwanda
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/uverbs.h
include/rdma/ib_verbs.h