target: Fix se_cmd->state_list leak regression during WRITE failure
authorNicholas Bellinger <nab@linux-iscsi.org>
Sat, 31 Aug 2013 22:12:01 +0000 (15:12 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Sep 2013 14:06:45 +0000 (07:06 -0700)
commita8f55b8e314fdc26deb92a1108ebfd413cae9dde
tree87d34ff1c9fe44a6c6fc94e6641da4a2ef6ba0b8
parent96dba890600864c6753c1db27bc46e4aa6a01f68
target: Fix se_cmd->state_list leak regression during WRITE failure

commit c130480b129fbfd7932ad7af3f4ffcea630b027f upstream.

This patch addresses a v3.11 specific regression where se_cmd->state_list
was being leaked during a fabric WRITE failure, when the fabric releases
an associated se_cmd descriptor before I/O submission occurs, and normal
fast path callbacks have a chance to call target_remove_from_state_list().

It was manifesting with Poison overwritten messages with iscsi-target
once an ImmediateData payload CRC32C failure occured.

This bug was originally introduced during v3.11-rc1 with the following
commit:

commit 0b66818ac6de67a6125ae203272fb76e79b3a20f
Author: Nicholas Bellinger <nab@linux-iscsi.org>
Date:   Thu Jun 6 01:36:41 2013 -0700

    target: Drop unnecessary CMD_T_DEV_ACTIVE check from transport_lun_remove_cmd

Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/target/target_core_transport.c