[clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.
authorSunho Kim <ksunhokim123@gmail.com>
Sat, 30 Jul 2022 20:42:16 +0000 (05:42 +0900)
committerSunho Kim <ksunhokim123@gmail.com>
Sat, 30 Jul 2022 20:42:57 +0000 (05:42 +0900)
commita8f2e24e48fddb3707301c9d24cc50ab778d4fda
tree1d043ca17bafdf367b09a82c1406b934bf2ee0f7
parent1d03b2efcd40eb8225a0b10afea86e8a1436681e
[clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

We have seen random symbol not found "__cxa_throw" error in fuschia build bots and out-of-tree users. The understanding have been that they are built without exception support, but it turned out that these platforms have LLVM_STATIC_LINK_CXX_STDLIB ON so that they link libstdc++ to llvm statically. The reason why this is problematic for clang-repl is that by default clang-repl tries to find symbols from symbol table of executable and dynamic libraries loaded by current process. It needs to load another libstdc++, but the platform that had LLVM_STATIC_LINK_CXX_STDLIB turned on is usally those with missing or obsolate shared libstdc++ in the first place -- trying to load it again would be destined to fail eventually with a risk to introuduce mixed libstdc++ versions.

A proper solution that doesn't take a workaround is statically link the same libstdc++ by clang-repl side, but this is not possible with old JIT linker runtimedyld. New just-in-time linker JITLink handles this relatively well, but it's not availalbe in majority of platforms. For now, this patch just disables the building of clang-repl when LLVM_STATIC_LINK_CXX_STDLIB is ON and removes the "__cxa_throw" check in exception unittest as well as reverting previous exception check flag patch.

Reviewed By: v.g.vassilev

Differential Revision: https://reviews.llvm.org/D130788
15 files changed:
clang/CMakeLists.txt
clang/test/CMakeLists.txt
clang/test/Interpreter/code-undo.cpp
clang/test/Interpreter/execute-weak.cpp
clang/test/Interpreter/execute.cpp
clang/test/Interpreter/global-dtor-win.cpp [deleted file]
clang/test/Interpreter/global-dtor.cpp
clang/test/Interpreter/lit.local.cfg [new file with mode: 0644]
clang/test/Interpreter/plugins.cpp
clang/test/Interpreter/simple-exception.cpp
clang/test/lit.cfg.py
clang/tools/CMakeLists.txt
clang/tools/clang-repl/ClangRepl.cpp
clang/unittests/CMakeLists.txt
clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp