rtpptdemux: Don't GST_FLOW_ERROR when ignoring invalid packets
authorJan Schmidt <jan@centricular.com>
Sun, 29 May 2022 10:27:38 +0000 (20:27 +1000)
committerJan Schmidt <jan@centricular.com>
Sun, 29 May 2022 10:27:38 +0000 (20:27 +1000)
commita8f18aef189e31edeac9cab2a746d8199b9e73c2
tree58e470f677b490f3819043f34c968ecb51ae17be
parent5762dfb15d4628958bf3f378d31e34151dd91225
rtpptdemux: Don't GST_FLOW_ERROR when ignoring invalid packets

https://bugzilla.gnome.org/show_bug.cgi?id=741398 changed
rtpptdemux in 2014 to not post a GST_ELEMENT_ERROR on the
bus when dropping an invalid (non-RTP) packet, but still
returned GST_FLOW_ERROR upstream - so the pipeline still
stops, but now without a useful bus error.

Return GST_FLOW_OK instead, so the pipeline keeps
running. Some old telephony equipment can send invalid
packets before the real RTP traffic starts.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2520>
subprojects/gst-plugins-good/gst/rtpmanager/gstrtpptdemux.c