cpufreq: Fix governor module removal race
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 23 Nov 2017 13:27:07 +0000 (14:27 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 4 Dec 2017 14:35:41 +0000 (15:35 +0100)
commita8b149d32b663c1a4105273295184b78f53d33cf
tree2e7dca6e097f43263e6a05fba403b1d1cef7dea0
parent70d1ff71161b1c56c6d025e6a957bc878dfd940b
cpufreq: Fix governor module removal race

It is possible to remove a cpufreq governor module after
cpufreq_parse_governor() has returned success in
store_scaling_governor() and before cpufreq_set_policy()
acquires a reference to it, because the governor list is
not protected during that period and nothing prevents the
governor from being unregistered then.

Prevent that from happening by acquiring an extra reference
to the governor module temporarily in cpufreq_parse_governor(),
under cpufreq_governor_mutex, and dropping it in
store_scaling_governor(), when cpufreq_set_policy() returns.

Note that the second cpufreq_parse_governor() call site is fine,
because it only cares about the policy member of new_policy.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c