drm/amdgpu fix incorrect sysfs remove behavior for xgmi
authorJack Zhang <Jack.Zhang1@amd.com>
Mon, 18 May 2020 03:15:52 +0000 (11:15 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 21 May 2020 16:48:42 +0000 (12:48 -0400)
commita89b5dae3e68e5a543c5bcbeb04cf9a1dec2e687
treeb474e14b15cc5c0561ebc38a557177496acb66bd
parent27a468eac53186fea97997e02510a6ff9a53558a
drm/amdgpu fix incorrect sysfs remove behavior for xgmi

Under xgmi setup,some sysfs fail to create for the second time of kmd
driver loading. It's due to sysfs nodes are not removed appropriately
in the last unlod time.

Changes of this patch:
1. remove sysfs for dev_attr_xgmi_error
2. remove sysfs_link adev->dev->kobj with target name.
   And it only needs to be removed once for a xgmi setup
3. remove sysfs_link hive->kobj with target name

In amdgpu_xgmi_remove_device:
1. amdgpu_xgmi_sysfs_rem_dev_info needs to be run per device
2. amdgpu_xgmi_sysfs_destroy needs to be run on the last node of
device.

v2: initialize array with memset

Signed-off-by: Jack Zhang <Jack.Zhang1@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c