Revert "remoteproc: qcom_q6v5_mss: map/unmap metadata region before/after use"
authorChristoph Hellwig <hch@lst.de>
Tue, 17 Jan 2023 08:58:34 +0000 (14:28 +0530)
committerBjorn Andersson <andersson@kernel.org>
Thu, 19 Jan 2023 03:36:17 +0000 (21:36 -0600)
commita899d542b687c9b04ccbd9eefabc829ba5fef791
tree14217b4e0a01e7fbeb68ee3074974d1fce2740f6
parenteb48137d783b4c845c7b081e32a73666326dcbb3
Revert "remoteproc: qcom_q6v5_mss: map/unmap metadata region before/after use"

This reverts commit fc156629b23a21181e473e60341e3a78af25a1d4.

This commit manages to do three API violations at once:

 - dereference the return value of dma_alloc_attrs with the
   DMA_ATTR_NO_KERNEL_MAPPING mapping, which is clearly forbidden and
   will do the wrong thing on various dma mapping implementations.  The
   fact that dma-direct uses a struct page as a cookie is an undocumented
   implementation detail
 - include dma-map-ops.h and use pgprot_dmacoherent despite a clear
   comment documenting that this is not acceptable
 - use of the VM_DMA_COHERENT for something that is not the dma-mapping
   code
 - use of VM_FLUSH_RESET_PERMS for vmap, while it is only supported for
   vmalloc

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230117085840.32356-6-quic_sibis@quicinc.com
drivers/remoteproc/qcom_q6v5_mss.c