Add missing-END_CATCH detection/protection (to gdb's TRY/CATCH/END_CATCH)
authorPedro Alves <palves@redhat.com>
Wed, 4 Oct 2017 08:55:29 +0000 (09:55 +0100)
committerPedro Alves <palves@redhat.com>
Wed, 4 Oct 2017 09:06:42 +0000 (10:06 +0100)
commita87c142792e4dcbec2bb3825e71f3ace044c2096
treebe277a205e9b7504123d6e681c14c95d96c0c192
parentbc3b087de2401c65c02730d346e8bea4dc0504ae
Add missing-END_CATCH detection/protection (to gdb's TRY/CATCH/END_CATCH)

While we still have cleanups (i.e., make_cleanup & co), we must be
sure to add END_CATCH at the end of a TRY/CATCH/END_CATCH construct.
However, it's currently too easy to miss adding the END_CATCH, because
the code compiles anyway without it.  I realized this when I noticed
that another patch I was working on missed several adding END_CATCH in
several new TRY/CATCH uses.

This commit fixes that by making TRY open a new scope that is only
closed by END_CATCH.  This way, if you forget to add the END_CATCH,
then compilation fails due to the unbalanced curly braces.

This caught a couple places where we were missing END_CATCH in current
master, also fixed by the patch.

gdb/ChangeLog:
2017-10-04  Pedro Alves  <palves@redhat.com>

* cli/cli-cmds.c (complete_command): Add missing END_CATCH.
* common/common-exceptions.h (TRY): Open an outermost scope.
Expand intro comment.
(CATCH): Reindent.
(END_CATCH): Close the outermost scope.
* completer.c (complete_line_internal): Add missing END_CATCH.
gdb/cli/cli-cmds.c
gdb/common/common-exceptions.h
gdb/completer.c