Fix completing an empty string
authorPedro Alves <palves@redhat.com>
Sat, 25 Nov 2017 00:20:31 +0000 (00:20 +0000)
committerPedro Alves <palves@redhat.com>
Sat, 25 Nov 2017 00:20:31 +0000 (00:20 +0000)
commita81aaca0578ee91ce1cee56c0a31e26c2a5ef581
tree798c788bd50a995f352ed34b91e10cf7dbd1883d
parent6a3c6ee41898743234d8fd9f9cab15f2ecdaba49
Fix completing an empty string

Earlier while working on the big completer rework series, I managed to
break

 (gdb) [TAB]

locally, and make GDB crash, but only notice a few weeks down the
road, because we have no test for that...

I also noticed that:

 (gdb)     [TAB]

didn't work (didn't show all commands as matches), even though
entering a command with leading whitespace works:

 (gdb)     help

This commit fixes the latter and adds a testcase that covers both
issues.

The gdb.base/completion.exp change is necessary because the new test
has a file name that also starts with "gdb.base/complet", making that
particular test ambiguous.  Adding another letter disambiguates.

gdb/ChangeLog:
2017-11-25   Pedro Alves  <palves@redhat.com>

* completer.c (complete_line_internal_1): Skip spaces until the
start of the command.

gdb/testsuite/ChangeLog:
2017-11-25   Pedro Alves  <palves@redhat.com>

* gdb.base/complete-empty.exp: New file.
* gdb.base/completion.exp: Adjust.
gdb/ChangeLog
gdb/completer.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/complete-empty.exp [new file with mode: 0644]
gdb/testsuite/gdb.base/completion.exp