perf top: Fix crash when annotating symbol
authorJiri Olsa <jolsa@kernel.org>
Wed, 15 Nov 2017 10:53:21 +0000 (11:53 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 17 Nov 2017 15:16:24 +0000 (12:16 -0300)
commita7eec4c677fe60c8760fa9054b578c743ff6a3ec
treec5244a20b4143d0142c08d1580caab0a311d8b08
parent244a1086aba97a6b673162fd6684c5c024b724db
perf top: Fix crash when annotating symbol

Ravi reported crash in perf top --stdio when annotating a function [1].
The issue was, that we don't pass evsel pointer into symbol__annotate()
function, which got over looked in the last annotation changes.

[1] https://marc.info/?l=linux-kernel&m=151060884412702&w=2

Committer note:

This fixes the crash, but makes it stumble into another bug, double
locking the annotation data structures, that is in turn fixed by the
next patch in this series.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-6eol035redpoqvxqnuiqudtc@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-top.c