netfilter: ebtables: fix fortify warnings in size_entry_mwt()
authorGONG, Ruiqi <gongruiqi1@huawei.com>
Wed, 9 Aug 2023 07:45:03 +0000 (15:45 +0800)
committerFlorian Westphal <fw@strlen.de>
Tue, 22 Aug 2023 13:13:20 +0000 (15:13 +0200)
commita7ed3465daa240bdf01a5420f64336fee879c09d
tree72c98ae8062442d373bd73a780bc0e55fdd3e9d0
parent43c2817225fce05701f062a996255007481935e2
netfilter: ebtables: fix fortify warnings in size_entry_mwt()

When compiling with gcc 13 and CONFIG_FORTIFY_SOURCE=y, the following
warning appears:

In function ‘fortify_memcpy_chk’,
    inlined from ‘size_entry_mwt’ at net/bridge/netfilter/ebtables.c:2118:2:
./include/linux/fortify-string.h:592:25: error: call to ‘__read_overflow2_field’
declared with attribute warning: detected read beyond size of field (2nd parameter);
maybe use struct_group()? [-Werror=attribute-warning]
  592 |                         __read_overflow2_field(q_size_field, size);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The compiler is complaining:

memcpy(&offsets[1], &entry->watchers_offset,
                       sizeof(offsets) - sizeof(offsets[0]));

where memcpy reads beyong &entry->watchers_offset to copy
{watchers,target,next}_offset altogether into offsets[]. Silence the
warning by wrapping these three up via struct_group().

Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
include/uapi/linux/netfilter_bridge/ebtables.h
net/bridge/netfilter/ebtables.c