PCI: aardvark: Do not clear status bits of masked interrupts
authorPali Rohár <pali@kernel.org>
Tue, 5 Oct 2021 18:09:45 +0000 (20:09 +0200)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Thu, 7 Oct 2021 13:23:32 +0000 (14:23 +0100)
commita7ca6d7fa3c02c032db5440ff392d96c04684c21
tree84abd698f172f7417b385544ab7012335be3cf88
parent46ef6090dbf590711cb12680b6eafde5fa21fe87
PCI: aardvark: Do not clear status bits of masked interrupts

The PCIE_ISR1_REG says which interrupts are currently set / active,
including those which are masked.

The driver currently reads this register and looks if some unmasked
interrupts are active, and if not, it clears status bits of _all_
interrupts, including the masked ones.

This is incorrect, since, for example, some drivers may poll these bits.

Remove this clearing, and also remove this early return statement
completely, since it does not change functionality in any way.

Link: https://lore.kernel.org/r/20211005180952.6812-7-kabel@kernel.org
Fixes: 8c39d710363c ("PCI: aardvark: Add Aardvark PCI host controller driver")
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Marek Behún <kabel@kernel.org>
Cc: stable@vger.kernel.org
drivers/pci/controller/pci-aardvark.c