NFC: Refactor ProcessWinMiniDump to use a more traditional pimpl idiom.
authorAdrian McCarthy <amccarth@google.com>
Mon, 29 Feb 2016 21:15:23 +0000 (21:15 +0000)
committerAdrian McCarthy <amccarth@google.com>
Mon, 29 Feb 2016 21:15:23 +0000 (21:15 +0000)
commita7ad58b61c79619d8a57b59db52acb22b020e576
tree01a98570071f290aa98c51d143e076685f1e219b
parent536183275d67c1de31066386070a2fe9b403e241
NFC:  Refactor ProcessWinMiniDump to use a more traditional pimpl idiom.

This is a mechanical refactor.  There should be no functional changes in this commit.

Instead of encapsulating just the Windows-specific data, ProcessWinMiniDump now uses a private implementation class.  This reduces indirections (in the source).  It makes it easier to add private helper methods without touching the header and allows them to have platform-specific types as parameters.  The only trick was that the pimpl class needed a back pointer in order to call a couple methods.

llvm-svn: 262256
lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.h