projects / platform / upstream / llvm.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 671a871) | patch
Revert "[lld-macho] Have path-related functions return std::string, not StringRef"
authorJez Ng <jezng@fb.com>
Sat, 19 Jun 2021 02:19:09 +0000 (22:19 -0400)
committerJez Ng <jezng@fb.com>
Sat, 19 Jun 2021 02:43:49 +0000 (22:43 -0400)
commita79c01832553a8a192ab157098662a9e8f2c16af
treebd44e290aef1cb076e2b6b5421671df8d8b677e7tree | snapshot
parent671a87104b8132e45718a9584cbb7ed97916683fcommit | diff
Revert "[lld-macho] Have path-related functions return std::string, not StringRef"

This reverts commit 1d31fb8d122b1117cf20a9edc09812db8472e930.

Making `rerootPath` return a temporary std::string caused a
use-after-free:

https://ci.chromium.org/ui/p/chromium/builders/try/win_upload_clang/1608/overview
lld/MachO/Driver.cpp diff | blob | history
lld/MachO/Driver.h diff | blob | history
lld/MachO/DriverUtils.cpp diff | blob | history
Domain: System / Toolchain;