drm/drm_vblank: set the dma-fence timestamp during send_vblank_event
authorVeera Sundaram Sankaran <veeras@codeaurora.org>
Sat, 16 Jan 2021 00:31:47 +0000 (16:31 -0800)
committerSumit Semwal <sumit.semwal@linaro.org>
Fri, 22 Jan 2021 10:52:29 +0000 (16:22 +0530)
commita78e7a51d2fa9d2f482b462be4299784c884d988
treef0ef023028cbd9662304a5bb872bb0ae661ed6ed
parent5a164ac4dbd21b82bcdc03186d40e455ff467fdc
drm/drm_vblank: set the dma-fence timestamp during send_vblank_event

The explicit out-fences in crtc are signaled as part of vblank event,
indicating all framebuffers present on the Atomic Commit request are
scanned out on the screen. Though the fence signal and the vblank event
notification happens at the same time, triggered by the same hardware
vsync event, the timestamp set in both are different. With drivers
supporting precise vblank timestamp the difference between the two
timestamps would be even higher. This might have an impact on use-mode
frameworks using these fence timestamps for purposes other than simple
buffer usage. For instance, the Android framework [1] uses the
retire-fences as an alternative to vblank when frame-updates are in
progress. Set the fence timestamp during send vblank event using a new
drm_send_event_timestamp_locked variant to avoid discrepancies.

[1] https://android.googlesource.com/platform/frameworks/native/+/master/
services/surfaceflinger/Scheduler/Scheduler.cpp#397

Changes in v2:
- Use drm_send_event_timestamp_locked to update fence timestamp
- add more information to commit text

Changes in v3:
- use same backend helper function for variants of drm_send_event to
avoid code duplications

Changes in v4:
- remove WARN_ON from drm_send_event_timestamp_locked

Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
Reviewed-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
  [sumits: minor parenthesis alignment correction]
Link: https://patchwork.freedesktop.org/patch/msgid/1610757107-11892-2-git-send-email-veeras@codeaurora.org
drivers/gpu/drm/drm_file.c
drivers/gpu/drm/drm_vblank.c
include/drm/drm_file.h