net: axienet: Fix race condition causing TX hang
authorRobert Hancock <hancock@sedsystems.ca>
Thu, 6 Jun 2019 22:28:17 +0000 (16:28 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Jul 2019 07:14:04 +0000 (09:14 +0200)
commita76f32cbd38c6bf6cfe841c2916ded1ad371eaa5
treecda9952cd727612b0240a53333e2741b6154e843
parent9d643358386d46c261e000a93f5eb28dd8009e33
net: axienet: Fix race condition causing TX hang

[ Upstream commit 7de44285c1f69ccfbe8be1d6a16fcd956681fee6 ]

It is possible that the interrupt handler fires and frees up space in
the TX ring in between checking for sufficient TX ring space and
stopping the TX queue in axienet_start_xmit. If this happens, the
queue wake from the interrupt handler will occur before the queue is
stopped, causing a lost wakeup and the adapter's transmit hanging.

To avoid this, after stopping the queue, check again whether there is
sufficient space in the TX ring. If so, wake up the queue again.

Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/xilinx/xilinx_axienet_main.c