usb: dwc3: gadget: Avoid duplicate requests to enable Run/Stop
authorWesley Cheng <quic_wcheng@quicinc.com>
Thu, 28 Jul 2022 02:06:47 +0000 (19:06 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 09:11:39 +0000 (11:11 +0200)
commita72eee6d905e433fbb15521336ea677144d0ec12
tree3fc72d9561f2d78de5f912d9b95ca0d5d4b11d95
parentf79a57d4091f12415c2624dc7fdbaa3b1ee56d27
usb: dwc3: gadget: Avoid duplicate requests to enable Run/Stop

[ Upstream commit 040f2dbd2010c43f33ad27249e6dac48456f4d99 ]

Relocate the pullups_connected check until after it is ensured that there
are no runtime PM transitions.  If another context triggered the DWC3
core's runtime resume, it may have already enabled the Run/Stop.  Do not
re-run the entire pullup sequence again, as it may issue a core soft
reset while Run/Stop is already set.

This patch depends on
  commit 69e131d1ac4e ("usb: dwc3: gadget: Prevent repeat pullup()")

Fixes: 77adb8bdf422 ("usb: dwc3: gadget: Allow runtime suspend if UDC unbinded")
Cc: stable <stable@kernel.org>
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Link: https://lore.kernel.org/r/20220728020647.9377-1-quic_wcheng@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/dwc3/gadget.c