PM / QoS: fix wrong error-checking condition
authorGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Fri, 23 Nov 2012 19:55:06 +0000 (20:55 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 23 Nov 2012 19:55:06 +0000 (20:55 +0100)
commita7227a0faa117d0bc532aea546ae5ac5f89e8ed7
treead2843227bd9d9baac592463a86e0f3d485ad9d9
parentf4a75d2eb7b1e2206094b901be09adb31ba63681
PM / QoS: fix wrong error-checking condition

dev_pm_qos_add_request() can return 0, 1, or a negative error code,
therefore the correct error test is "if (error < 0)." Checking just for
non-zero return code leads to erroneous setting of the req->dev pointer
to NULL, which then leads to a repeated call to
dev_pm_qos_add_ancestor_request() in st1232_ts_irq_handler(). This in turn
leads to an Oops, when the I2C host adapter is unloaded and reloaded again
because of the inconsistent state of its QoS request list.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/power/qos.c