[mlir:Transforms] Move out the remaining non-dialect independent transforms and utilities
authorRiver Riddle <riddleriver@gmail.com>
Fri, 21 Jan 2022 01:32:31 +0000 (17:32 -0800)
committerRiver Riddle <riddleriver@gmail.com>
Tue, 25 Jan 2022 03:25:53 +0000 (19:25 -0800)
commita70aa7bb0d9a6066831b339e0a09a2c1bc74fe2b
tree7e807bcabf3cda9403351e442a3f74b3fae01756
parent2e2c0738e80e9c2b7c1413ca4719d5be2df4c6b5
[mlir:Transforms] Move out the remaining non-dialect independent transforms and utilities

This has been a major TODO for a very long time, and is necessary for establishing a proper
dialect-free dependency layering for the Transforms library. Code was moved to effectively
two main locations:

* Affine/
There was quite a bit of affine dialect related code in Transforms/ do to historical reasons
(of a time way into MLIR's past). The following headers were moved to:
Transforms/LoopFusionUtils.h -> Dialect/Affine/LoopFusionUtils.h
Transforms/LoopUtils.h -> Dialect/Affine/LoopUtils.h
Transforms/Utils.h -> Dialect/Affine/Utils.h

The following transforms were also moved:
AffineLoopFusion, AffinePipelineDataTransfer, LoopCoalescing

* SCF/
Only one SCF pass was in Transforms/ (likely accidentally placed here): ParallelLoopCollapsing
The SCF specific utilities in LoopUtils have been moved to SCF/Utils.h

* Misc:
mlir::moveLoopInvariantCode was also moved to LoopLikeInterface.h given
that it is a simple utility defined in terms of LoopLikeOpInterface.

Differential Revision: https://reviews.llvm.org/D117848
70 files changed:
mlir/include/mlir/Dialect/Affine/LoopFusionUtils.h [moved from mlir/include/mlir/Transforms/LoopFusionUtils.h with 98% similarity]
mlir/include/mlir/Dialect/Affine/LoopUtils.h [moved from mlir/include/mlir/Transforms/LoopUtils.h with 85% similarity]
mlir/include/mlir/Dialect/Affine/Passes.h
mlir/include/mlir/Dialect/Affine/Passes.td
mlir/include/mlir/Dialect/Affine/Utils.h
mlir/include/mlir/Dialect/SCF/Passes.h
mlir/include/mlir/Dialect/SCF/Passes.td
mlir/include/mlir/Dialect/SCF/Utils.h
mlir/include/mlir/Interfaces/LoopLikeInterface.h
mlir/include/mlir/Transforms/ControlFlowSinkUtils.h [new file with mode: 0644]
mlir/include/mlir/Transforms/Passes.h
mlir/include/mlir/Transforms/Passes.td
mlir/include/mlir/Transforms/Utils.h [deleted file]
mlir/lib/Conversion/SCFToGPU/SCFToGPU.cpp
mlir/lib/Conversion/SCFToStandard/SCFToStandard.cpp
mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
mlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp
mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp
mlir/lib/Dialect/Affine/Transforms/AffineLoopInvariantCodeMotion.cpp
mlir/lib/Dialect/Affine/Transforms/AffineParallelize.cpp
mlir/lib/Dialect/Affine/Transforms/CMakeLists.txt
mlir/lib/Dialect/Affine/Transforms/LoopCoalescing.cpp [moved from mlir/lib/Transforms/LoopCoalescing.cpp with 97% similarity]
mlir/lib/Dialect/Affine/Transforms/LoopFusion.cpp [moved from mlir/lib/Transforms/LoopFusion.cpp with 99% similarity]
mlir/lib/Dialect/Affine/Transforms/LoopTiling.cpp
mlir/lib/Dialect/Affine/Transforms/LoopUnroll.cpp
mlir/lib/Dialect/Affine/Transforms/LoopUnrollAndJam.cpp
mlir/lib/Dialect/Affine/Transforms/PassDetail.h
mlir/lib/Dialect/Affine/Transforms/PipelineDataTransfer.cpp [moved from mlir/lib/Transforms/PipelineDataTransfer.cpp with 99% similarity]
mlir/lib/Dialect/Affine/Transforms/SimplifyAffineStructures.cpp
mlir/lib/Dialect/Affine/Utils/CMakeLists.txt
mlir/lib/Dialect/Affine/Utils/LoopFusionUtils.cpp [moved from mlir/lib/Transforms/Utils/LoopFusionUtils.cpp with 99% similarity]
mlir/lib/Dialect/Affine/Utils/LoopUtils.cpp [moved from mlir/lib/Transforms/Utils/LoopUtils.cpp with 81% similarity]
mlir/lib/Dialect/Affine/Utils/Utils.cpp
mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp
mlir/lib/Dialect/Linalg/Transforms/CodegenStrategy.cpp
mlir/lib/Dialect/Linalg/Transforms/HoistPadding.cpp
mlir/lib/Dialect/Linalg/Transforms/Hoisting.cpp
mlir/lib/Dialect/Linalg/Transforms/LinalgStrategyPasses.cpp
mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
mlir/lib/Dialect/Linalg/Utils/Utils.cpp
mlir/lib/Dialect/MemRef/Transforms/NormalizeMemRefs.cpp
mlir/lib/Dialect/SCF/Transforms/CMakeLists.txt
mlir/lib/Dialect/SCF/Transforms/ParallelLoopCollapsing.cpp [moved from mlir/lib/Transforms/ParallelLoopCollapsing.cpp with 91% similarity]
mlir/lib/Dialect/SCF/Transforms/Utils.cpp
mlir/lib/Dialect/Vector/VectorTransferSplitRewritePatterns.cpp
mlir/lib/Dialect/Vector/VectorTransforms.cpp
mlir/lib/Dialect/Vector/VectorUnrollDistribute.cpp
mlir/lib/Interfaces/LoopLikeInterface.cpp
mlir/lib/Transforms/CMakeLists.txt
mlir/lib/Transforms/CSE.cpp
mlir/lib/Transforms/ControlFlowSink.cpp
mlir/lib/Transforms/LoopInvariantCodeMotion.cpp
mlir/lib/Transforms/PassDetail.h
mlir/lib/Transforms/Utils/CMakeLists.txt
mlir/lib/Transforms/Utils/ControlFlowSinkUtils.cpp
mlir/lib/Transforms/Utils/DialectConversion.cpp
mlir/lib/Transforms/Utils/Utils.cpp [deleted file]
mlir/test/lib/Dialect/Affine/CMakeLists.txt
mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp
mlir/test/lib/Dialect/Affine/TestAffineLoopParametricTiling.cpp
mlir/test/lib/Dialect/Affine/TestLoopFusion.cpp [moved from mlir/test/lib/Transforms/TestLoopFusion.cpp with 98% similarity]
mlir/test/lib/Dialect/Affine/TestLoopMapping.cpp [moved from mlir/test/lib/Transforms/TestLoopMapping.cpp with 96% similarity]
mlir/test/lib/Dialect/Affine/TestLoopPermutation.cpp
mlir/test/lib/Dialect/Affine/TestVectorizationUtils.cpp
mlir/test/lib/Dialect/SCF/CMakeLists.txt
mlir/test/lib/Dialect/SCF/TestLoopParametricTiling.cpp [moved from mlir/test/lib/Transforms/TestLoopParametricTiling.cpp with 93% similarity]
mlir/test/lib/Dialect/SCF/TestLoopUnrolling.cpp [moved from mlir/test/lib/Transforms/TestLoopUnrolling.cpp with 97% similarity]
mlir/test/lib/Transforms/CMakeLists.txt
mlir/test/lib/Transforms/TestConstantFold.cpp
mlir/unittests/Transforms/CMakeLists.txt