md/raid5-cache: fix a deadlock in r5l_exit_log()
authorYu Kuai <yukuai3@huawei.com>
Sat, 8 Jul 2023 09:17:27 +0000 (17:17 +0800)
committerSong Liu <song@kernel.org>
Tue, 15 Aug 2023 16:37:27 +0000 (09:37 -0700)
commita705b11b358dee677aad80630e7608b2d5f56691
treef9beddaeaf22c8aad64f734715b0c6a28d84464b
parent66a6a5d0ec852eaced589da066376e69397cd71e
md/raid5-cache: fix a deadlock in r5l_exit_log()

Commit b13015af94cf ("md/raid5-cache: Clear conf->log after finishing
work") introduce a new problem:

// caller hold reconfig_mutex
r5l_exit_log
 flush_work(&log->disable_writeback_work)
r5c_disable_writeback_async
 wait_event
  /*
   * conf->log is not NULL, and mddev_trylock()
   * will fail, wait_event() can never pass.
   */
 conf->log = NULL

Fix this problem by setting 'config->log' to NULL before wake_up() as it
used to be, so that wait_event() from r5c_disable_writeback_async() can
exist. In the meantime, move forward md_unregister_thread() so that
null-ptr-deref this commit fixed can still be fixed.

Fixes: b13015af94cf ("md/raid5-cache: Clear conf->log after finishing work")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20230708091727.1417894-1-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org>
drivers/md/raid5-cache.c