tcp/dccp: fix lockdep splat in inet_csk_route_req()
authorEric Dumazet <edumazet@google.com>
Sun, 22 Oct 2017 19:33:57 +0000 (12:33 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 23 Oct 2017 04:45:25 +0000 (05:45 +0100)
commita6ca7abe53633d08eea1c6756cb49c9b2d4c90bf
tree800cd8cbbd05b2d687ed7fc8d5374e318e3ba985
parent3a91d29f20276fa7cd4d0c9c7f3e78b30708159d
tcp/dccp: fix lockdep splat in inet_csk_route_req()

This patch fixes the following lockdep splat in inet_csk_route_req()

  lockdep_rcu_suspicious
  inet_csk_route_req
  tcp_v4_send_synack
  tcp_rtx_synack
  inet_rtx_syn_ack
  tcp_fastopen_synack_time
  tcp_retransmit_timer
  tcp_write_timer_handler
  tcp_write_timer
  call_timer_fn

Thread running inet_csk_route_req() owns a reference on the request
socket, so we have the guarantee ireq->ireq_opt wont be changed or
freed.

lockdep can enforce this invariant for us.

Fixes: c92e8c02fe66 ("tcp/dccp: fix ireq->opt races")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/inet_connection_sock.c